Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e249cea3 authored by Yoshihiro Shimoda's avatar Yoshihiro Shimoda Committed by Greg Kroah-Hartman
Browse files

net: ravb: Fix possible hang if RIS2_QFF1 happen 



[ Upstream commit f3c07758c9007a6bfff5290d9e19d3c41930c897 ]

Since this driver enables the interrupt by RIC2_QFE1, this driver
should clear the interrupt flag if it happens. Otherwise, the interrupt
causes to hang the system.

Note that this also fix a minor coding style (a comment indentation)
around the fixed code.

Fixes: c156633f ("Renesas Ethernet AVB driver proper")
Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a7585028

drivers/net/ethernet/renesas/ravb_main.c

+2 −2
Original line number Diff line number Diff line
@@ -736,7 +736,7 @@ static void ravb_error_interrupt(struct net_device *ndev) 
	ravb_write(ndev, ~(EIS_QFS | EIS_RESERVED), EIS);

	if (eis & EIS_QFS) {

		ris2 = ravb_read(ndev, RIS2);

		ravb_write(ndev, ~(RIS2_QFF0 | RIS2_RFFF | RIS2_RESERVED),

		ravb_write(ndev, ~(RIS2_QFF0 | RIS2_QFF1 | RIS2_RFFF | RIS2_RESERVED),

			   RIS2);



		/* Receive Descriptor Empty int */