Commit e23f1d9e authored Feb 27, 2023 by Dan Carpenter Committed by Greg Kroah-Hartman Mar 11, 2023

thermal: intel: quark_dts: fix error pointer dereference



[ Upstream commit f1b930e740811d416de4d2074da48b6633a672c8 ]

If alloc_soc_dts() fails, then we can just return.  Trying to free
"soc_dts" will lead to an Oops.

Fixes: 8c187693 ("thermal: intel Quark SoC X1000 DTS thermal driver")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 584f664c

drivers/thermal/intel/intel_quark_dts_thermal.c

+2 −10

Original line number	Diff line number	Diff line
		@@ -440,22 +440,14 @@ MODULE_DEVICE_TABLE(x86cpu, qrk_thermal_ids);

		static int __init intel_quark_thermal_init(void)
		{
		int err = 0;

		if (!x86_match_cpu(qrk_thermal_ids) \|\| !iosf_mbi_available())
		return -ENODEV;

		soc_dts = alloc_soc_dts();
		if (IS_ERR(soc_dts)) {
		err = PTR_ERR(soc_dts);
		goto err_free;
		}
		if (IS_ERR(soc_dts))
		return PTR_ERR(soc_dts);

		return 0;

		err_free:
		free_soc_dts(soc_dts);
		return err;
		}

		static void __exit intel_quark_thermal_exit(void)