Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit e20bfeb0 authored by Yizhuo's avatar Yizhuo Committed by Mark Brown
Browse files

ASoC: rt5651: Variable "ret" in function rt5651_i2c_probe() could be uninitialized 



In function rt5651_i2c_probe(), local variable "ret" could
be uninitialized if function regmap_read() returns -EINVAL.
However, this value is used in if statement. This is
potentially unsafe.

Signed-off-by: default avatarYizhuo <yzhai003@ucr.edu>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5e484ec1

sound/soc/codecs/rt5651.c

+5 −1
Original line number Diff line number Diff line
@@ -2181,6 +2181,7 @@ static int rt5651_i2c_probe(struct i2c_client *i2c, 
{

	struct rt5651_priv *rt5651;

	int ret;

	int err;



	rt5651 = devm_kzalloc(&i2c->dev, sizeof(*rt5651),

				GFP_KERNEL);
@@ -2197,7 +2198,10 @@ static int rt5651_i2c_probe(struct i2c_client *i2c, 
		return ret;

	}



	regmap_read(rt5651->regmap, RT5651_DEVICE_ID, &ret);

	err = regmap_read(rt5651->regmap, RT5651_DEVICE_ID, &ret);

	if (err)

		return err;



	if (ret != RT5651_DEVICE_ID_VALUE) {

		dev_err(&i2c->dev,

			"Device with ID register %#x is not rt5651\n", ret);