Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e206d3da authored by Michael Holzheu's avatar Michael Holzheu Committed by Martin Schwidefsky
Browse files

s390/sclp_sdias: Add missing break and "fall through" 



If the last block of the HSA is read, EVSTATE_ALL_STORED is returned
by SCLP. Because of a missing break in the switch statement two trace
entries are written in this case: "all stored" and "part stored".

This patch adds the missing break and also adds a "fall through"
comment to improve the readability.

Signed-off-by: default avatarMichael Holzheu <holzheu@linux.vnet.ibm.com>
Reported-by: default avatarDavid A Gilbert <DavidAGilbert@uk.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent d0503513

drivers/s390/char/sclp_sdias.c

+2 −0
Original line number Diff line number Diff line
@@ -242,11 +242,13 @@ int sclp_sdias_copy(void *dest, int start_blk, int nr_blks) 
	switch (sdias_evbuf.event_status) {

		case EVSTATE_ALL_STORED:

			TRACE("all stored\n");

			break;

		case EVSTATE_PART_STORED:

			TRACE("part stored: %i\n", sdias_evbuf.blk_cnt);

			break;

		case EVSTATE_NO_DATA:

			TRACE("no data\n");

			/* fall through */

		default:

			pr_err("Error from SCLP while copying hsa. "

			       "Event status = %x\n",