Commit e1746c27 authored Aug 12, 2021 by Dan Carpenter Committed by Greg Kroah-Hartman Sep 22, 2021

PCI: Fix pci_dev_str_match_path() alloc while atomic bug

[ Upstream commit 7eb6ea4148579b85540a41d57bcec315b8af8ff8 ]

pci_dev_str_match_path() is often called with a spinlock held so the
allocation has to be atomic.  The call tree is:

  pci_specified_resource_alignment() <-- takes spin_lock();
    pci_dev_str_match()
      pci_dev_str_match_path()

Fixes: 45db3370 ("PCI: Allow specifying devices using a base bus and path of devfns")
Link: https://lore.kernel.org/r/20210812070004.GC31863@kili


Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent beaf65f0

drivers/pci/pci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -224,7 +224,7 @@ static int pci_dev_str_match_path(struct pci_dev dev, const char path,

		*endptr = strchrnul(path, ';');

		wpath = kmemdup_nul(path, *endptr - path, GFP_KERNEL);
		wpath = kmemdup_nul(path, *endptr - path, GFP_ATOMIC);
		if (!wpath)
		return -ENOMEM;