Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e14e3856 authored by Tan Tee Min's avatar Tan Tee Min Committed by Greg Kroah-Hartman
Browse files

net: stmmac: disable Split Header (SPH) for Intel platforms 



commit 47f753c1108e287edb3e27fad8a7511a9d55578e upstream.

Based on DesignWare Ethernet QoS datasheet, we are seeing the limitation
of Split Header (SPH) feature is not supported for Ipv4 fragmented packet.
This SPH limitation will cause ping failure when the packets size exceed
the MTU size. For example, the issue happens once the basic ping packet
size is larger than the configured MTU size and the data is lost inside
the fragmented packet, replaced by zeros/corrupted values, and leads to
ping fail.

So, disable the Split Header for Intel platforms.

v2: Add fixes tag in commit message.

Fixes: 67afd6d1("net: stmmac: Add Split Header support and enable it in XGMAC cores")
Cc: <stable@vger.kernel.org> # 5.10.x
Suggested-by: default avatarOng, Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: default avatarMohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
Signed-off-by: default avatarWong Vee Khee <vee.khee.wong@linux.intel.com>
Signed-off-by: default avatarTan Tee Min <tee.min.tan@linux.intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarTan Tee Min <tee.min.tan@linux.intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9ea8e6a8

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+1 −1
Original line number Diff line number Diff line
@@ -4531,7 +4531,7 @@ int stmmac_dvr_probe(struct device *device, 
		dev_info(priv->device, "TSO feature enabled\n");

	}



	if (priv->dma_cap.sphen) {

	if (priv->dma_cap.sphen && !priv->plat->sph_disable) {

		ndev->hw_features |= NETIF_F_GRO;

		priv->sph = true;

		dev_info(priv->device, "SPH feature enabled\n");

drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c

+1 −0
Original line number Diff line number Diff line
@@ -119,6 +119,7 @@ static int intel_mgbe_common_data(struct pci_dev *pdev, 
	plat->has_gmac4 = 1;

	plat->force_sf_dma_mode = 0;

	plat->tso_en = 1;

	plat->sph_disable = 1;



	plat->rx_sched_algorithm = MTL_RX_ALGORITHM_SP;

include/linux/stmmac.h

+1 −0
Original line number Diff line number Diff line
@@ -179,5 +179,6 @@ struct plat_stmmacenet_data { 
	int mac_port_sel_speed;

	bool en_tx_lpi_clockgating;

	int has_xgmac;

	bool sph_disable;

};

#endif