Commit e13a5d69 authored Oct 05, 2018 by Eduardo Habkost Committed by Arnaldo Carvalho de Melo Oct 08, 2018

perf python: Make clang_has_option() work on Python 3



Use a bytes literal so it works with Python 3's version of Popen().
Note that the b"..." syntax requires Python 2.6+.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20181005204058.7966-2-ehabkost@redhat.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 1e44224f

tools/perf/util/setup.py

+1 −1

Original line number	Diff line number	Diff line
		@@ -5,7 +5,7 @@ from subprocess import Popen, PIPE
		from re import sub

		def clang_has_option(option):
		return [o for o in Popen(['clang', option], stderr=PIPE).stderr.readlines() if "unknown argument" in o] == [ ]
		return [o for o in Popen(['clang', option], stderr=PIPE).stderr.readlines() if b"unknown argument" in o] == [ ]

		cc = getenv("CC")
		if cc == "clang":