Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e12fac07 authored by Zhu Wang's avatar Zhu Wang Committed by Greg Kroah-Hartman
Browse files

scsi: core: Fix possible memory leak if device_add() fails 



commit 04b5b5cb0136ce970333a9c6cec7e46adba1ea3a upstream.

If device_add() returns error, the name allocated by dev_set_name() needs
be freed. As the comment of device_add() says, put_device() should be used
to decrease the reference count in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanp().

Fixes: ee959b00 ("SCSI: convert struct class_device to struct device")
Signed-off-by: default avatarZhu Wang <wangzhu9@huawei.com>
Link: https://lore.kernel.org/r/20230803020230.226903-1-wangzhu9@huawei.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cea09922

drivers/scsi/raid_class.c

+1 −0
Original line number Diff line number Diff line
@@ -248,6 +248,7 @@ int raid_component_add(struct raid_template *r,struct device *raid_dev, 
	return 0;



err_out:

	put_device(&rc->dev);

	list_del(&rc->node);

	rd->component_count--;

	put_device(component_dev);