Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e1090581 authored by Peng Wu's avatar Peng Wu Committed by Greg Kroah-Hartman
Browse files

ARM: hisi: Add missing of_node_put after of_find_compatible_node 



[ Upstream commit 9bc72e47d4630d58a840a66a869c56b29554cfe4 ]

of_find_compatible_node  will increment the refcount of the returned
device_node. Calling of_node_put() to avoid the refcount leak

Signed-off-by: default avatarPeng Wu <wupeng58@huawei.com>
Signed-off-by: default avatarWei Xu <xuwei5@hisilicon.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 2f46a955

arch/arm/mach-hisi/platsmp.c

+4 −0
Original line number Diff line number Diff line
@@ -67,14 +67,17 @@ static void __init hi3xxx_smp_prepare_cpus(unsigned int max_cpus) 
		}

		ctrl_base = of_iomap(np, 0);

		if (!ctrl_base) {

			of_node_put(np);

			pr_err("failed to map address\n");

			return;

		}

		if (of_property_read_u32(np, "smp-offset", &offset) < 0) {

			of_node_put(np);

			pr_err("failed to find smp-offset property\n");

			return;

		}

		ctrl_base += offset;

		of_node_put(np);

	}

}
@@ -160,6 +163,7 @@ static int hip01_boot_secondary(unsigned int cpu, struct task_struct *idle) 
	if (WARN_ON(!node))

		return -1;

	ctrl_base = of_iomap(node, 0);

	of_node_put(node);



	/* set the secondary core boot from DDR */

	remap_reg_value = readl_relaxed(ctrl_base + REG_SC_CTRL);