Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e0eca928 authored by Jeremy Linton's avatar Jeremy Linton Committed by Greg Kroah-Hartman
Browse files

net: bcmgenet: Don't claim WOL when its not available 



[ Upstream commit 00b022f8f876a3a036b0df7f971001bef6398605 ]

Some of the bcmgenet platforms don't correctly support WOL, yet
ethtool returns:

"Supports Wake-on: gsf"

which is false.

Ideally if there isn't a wol_irq, or there is something else that
keeps the device from being able to wakeup it should display:

"Supports Wake-on: d"

This patch checks whether the device can wakup, before using the
hard-coded supported flags. This corrects the ethtool reporting, as
well as the WOL configuration because ethtool verifies that the mode
is supported before attempting it.

Fixes: c51de7f3 ("net: bcmgenet: add Wake-on-LAN support code")
Signed-off-by: default avatarJeremy Linton <jeremy.linton@arm.com>
Tested-by: default avatarPeter Robinson <pbrobinson@gmail.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20220310045535.224450-1-jeremy.linton@arm.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent bbf59d7a

drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c

+7 −0
Original line number Diff line number Diff line
@@ -41,6 +41,13 @@ 
void bcmgenet_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)

{

	struct bcmgenet_priv *priv = netdev_priv(dev);

	struct device *kdev = &priv->pdev->dev;



	if (!device_can_wakeup(kdev)) {

		wol->supported = 0;

		wol->wolopts = 0;

		return;

	}



	wol->supported = WAKE_MAGIC | WAKE_MAGICSECURE;

	wol->wolopts = priv->wolopts;