Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e0bfb960 authored by Arend van Spriel's avatar Arend van Spriel Committed by Kalle Valo
Browse files

brcmfmac: simply remove flowring if bus is down 



When the bus is down, eg. due to rmmod, there is no need to
attempt to inform firmware about it.

Reviewed-by: default avatarHante Meuleman <hante.meuleman@broadcom.com>
Reviewed-by: default avatarPieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Reviewed-by: default avatarFranky Lin <franky.lin@broadcom.com>
Signed-off-by: default avatarArend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 1ac11ae9

drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c

+7 −0
Original line number Diff line number Diff line
@@ -1398,6 +1398,13 @@ void brcmf_msgbuf_delete_flowring(struct brcmf_pub *drvr, u16 flowid) 
	u8 ifidx;

	int err;



	/* no need to submit if firmware can not be reached */

	if (drvr->bus_if->state != BRCMF_BUS_UP) {

		brcmf_dbg(MSGBUF, "bus down, flowring will be removed\n");

		brcmf_msgbuf_remove_flowring(msgbuf, flowid);

		return;

	}



	commonring = msgbuf->commonrings[BRCMF_H2D_MSGRING_CONTROL_SUBMIT];

	brcmf_commonring_lock(commonring);

	ret_ptr = brcmf_commonring_reserve_for_write(commonring);