Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e09b74d0 authored by Ariel Elior's avatar Ariel Elior Committed by David S. Miller
Browse files

bnx2x: Zero VFs starting MACs 



Hypervisor/Supervisor should set the VF's MAC prior to its load;
Using a randomly generated MAC as a default is a bad practice.

Signed-off-by: default avatarAriel Elior <ariele@broadcom.com>
Signed-off-by: default avatarYuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: default avatarEilon Greenstein <eilong@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c48b22da

drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

+5 −1
Original line number Diff line number Diff line
@@ -11406,7 +11406,7 @@ static int bnx2x_init_bp(struct bnx2x *bp) 
		if (rc)

			return rc;

	} else {

		random_ether_addr(bp->dev->dev_addr);

		eth_zero_addr(bp->dev->dev_addr);

	}



	bnx2x_set_modes_bitmap(bp);
@@ -11865,6 +11865,10 @@ static int bnx2x_validate_addr(struct net_device *dev) 
{

	struct bnx2x *bp = netdev_priv(dev);



	/* query the bulletin board for mac address configured by the PF */

	if (IS_VF(bp))

		bnx2x_sample_bulletin(bp);



	if (!bnx2x_is_valid_ether_addr(bp, dev->dev_addr)) {

		BNX2X_ERR("Non-valid Ethernet address\n");

		return -EADDRNOTAVAIL;