Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e07a8943 authored by Sachin Kamat's avatar Sachin Kamat Committed by Dmitry Torokhov
Browse files

Input: apbps2 - convert to devm_ioremap_resource() 



Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: default avatarSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 39fbe585

drivers/input/serio/apbps2.c

+3 −5
Original line number Original line Diff line number Diff line
@@ -147,11 +147,9 @@ static int apbps2_of_probe(struct platform_device *ofdev) 




	/* Find Device Address */

	/* Find Device Address */

	res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);

	res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);

	priv->regs = devm_request_and_ioremap(&ofdev->dev, res);

	priv->regs = devm_ioremap_resource(&ofdev->dev, res);

	if (!priv->regs) {

	if (IS_ERR(priv->regs))

		dev_err(&ofdev->dev, "io-regs mapping failed\n");

		return PTR_ERR(priv->regs);

		return -EBUSY;

	}





	/* Reset hardware, disable interrupt */

	/* Reset hardware, disable interrupt */

	iowrite32be(0, &priv->regs->ctrl);

	iowrite32be(0, &priv->regs->ctrl);