Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e06351a0 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix issues connecting with nvme initiator 



In the lpfc discovery engine, when as a nvme target, where the driver
was performing mailbox io with the adapter for port login when a NVME
PRLI is received from the host. Rather than queue and eventually get
back to sending a response after the mailbox traffic, the driver
rejected the io with an error response.

Turns out this particular initiator didn't like the rejection values
(unable to process command/command in progress) so it never attempted a
retry of the PRLI. Thus the host never established nvme connectivity
with the lpfc target.

By changing the rejection values (to Logical Busy/nothing more), the
initiator accepted the response and would retry the PRLI, resulting in
nvme connectivity.

Signed-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9de416ac

drivers/scsi/lpfc/lpfc_nportdisc.c

+2 −2
Original line number Diff line number Diff line
@@ -1603,8 +1603,8 @@ lpfc_rcv_prli_reglogin_issue(struct lpfc_vport *vport, 
			 * rpi registration does complete.

			 */

			memset(&stat, 0, sizeof(struct ls_rjt));

			stat.un.b.lsRjtRsnCode = LSRJT_UNABLE_TPC;

			stat.un.b.lsRjtRsnCodeExp = LSEXP_CMD_IN_PROGRESS;

			stat.un.b.lsRjtRsnCode = LSRJT_LOGICAL_BSY;

			stat.un.b.lsRjtRsnCodeExp = LSEXP_NOTHING_MORE;

			lpfc_els_rsp_reject(vport, stat.un.lsRjtError, cmdiocb,

					    ndlp, NULL);

			return ndlp->nlp_state;