Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e048a0b2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Oded Gabbay
Browse files

amdkfd: fix an error handling bug in pqm_create_queue() 



The call to kernel_queue_uninit(NULL) will trigger a BUG(), and also the
error code is incorrect.

Fixes: 45102048 ('amdkfd: Add process queue manager module')
Reviewed-by: default avatarOded Gabbay <oded.gabbay@amd.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@amd.com>
parent 66333cb3

drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c

+1 −1
Original line number Diff line number Diff line
@@ -208,7 +208,7 @@ int pqm_create_queue(struct process_queue_manager *pqm, 
	case KFD_QUEUE_TYPE_DIQ:

		kq = kernel_queue_init(dev, KFD_QUEUE_TYPE_DIQ);

		if (kq == NULL) {

			kernel_queue_uninit(kq);

			retval = -ENOMEM;

			goto err_create_queue;

		}

		kq->queue->properties.queue_id = *qid;