Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e0241fb0 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Jens Axboe
Browse files

block: aoe: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: "Ed L. Cashin" <ed.cashin@acm.org>
Cc: linux-block@vger.kernel.org
Cc: Omar Sandoval <osandov@osandov.com>
Acked-by: default avatarJustin Sanders <justin@coraid.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent ca097206

drivers/block/aoe/aoeblk.c

+2 −14
Original line number Diff line number Diff line
@@ -196,7 +196,6 @@ static const struct file_operations aoe_debugfs_fops = { 
static void

aoedisk_add_debugfs(struct aoedev *d)

{

	struct dentry *entry;

	char *p;



	if (aoe_debugfs_dir == NULL)
@@ -207,15 +206,8 @@ aoedisk_add_debugfs(struct aoedev *d) 
	else

		p++;

	BUG_ON(*p == '\0');

	entry = debugfs_create_file(p, 0444, aoe_debugfs_dir, d,

	d->debugfs = debugfs_create_file(p, 0444, aoe_debugfs_dir, d,

					 &aoe_debugfs_fops);

	if (IS_ERR_OR_NULL(entry)) {

		pr_info("aoe: cannot create debugfs file for %s\n",

			d->gd->disk_name);

		return;

	}

	BUG_ON(d->debugfs);

	d->debugfs = entry;

}

void

aoedisk_rm_debugfs(struct aoedev *d)
@@ -472,10 +464,6 @@ aoeblk_init(void) 
	if (buf_pool_cache == NULL)

		return -ENOMEM;

	aoe_debugfs_dir = debugfs_create_dir("aoe", NULL);

	if (IS_ERR_OR_NULL(aoe_debugfs_dir)) {

		pr_info("aoe: cannot create debugfs directory\n");

		aoe_debugfs_dir = NULL;

	}

	return 0;

}