Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df997abe authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Konrad Rzeszutek Wilk
Browse files

iscsi_ibft: Fix missing break in switch statement 



Add missing break statement in order to prevent the code from falling
through to case ISCSI_BOOT_TGT_NAME, which is unnecessary.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: b33a84a3 ("ibft: convert iscsi_ibft module to iscsi boot lib")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
parent d1393711

drivers/firmware/iscsi_ibft.c

+1 −0
Original line number Diff line number Diff line
@@ -542,6 +542,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type) 
	case ISCSI_BOOT_TGT_NIC_ASSOC:

	case ISCSI_BOOT_TGT_CHAP_TYPE:

		rc = S_IRUGO;

		break;

	case ISCSI_BOOT_TGT_NAME:

		if (tgt->tgt_name_len)

			rc = S_IRUGO;