Commit df0b024a authored Aug 25, 2022 by Xu Qiang Committed by Greg Kroah-Hartman Oct 26, 2022

spi: qup: add missing clk_disable_unprepare on error in spi_qup_pm_resume_runtime()



[ Upstream commit 494a22765ce479c9f8ad181c5d24cffda9f534bb ]

Add the missing clk_disable_unprepare() before return
from spi_qup_pm_resume_runtime() in the error handling case.

Fixes: dae1a770 (“spi: qup: Handle clocks in pm_runtime suspend and resume”)
Signed-off-by: Xu Qiang <xuqiang36@huawei.com>
Link: https://lore.kernel.org/r/20220825065324.68446-2-xuqiang36@huawei.com


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 026ffbb0

drivers/spi/spi-qup.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1199,8 +1199,10 @@ static int spi_qup_pm_resume_runtime(struct device *device)
		return ret;

		ret = clk_prepare_enable(controller->cclk);
		if (ret)
		if (ret) {
		clk_disable_unprepare(controller->iclk);
		return ret;
		}

		/* Disable clocks auto gaiting */
		config = readl_relaxed(controller->base + QUP_CONFIG);