Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ded52fbe authored by ZhangXiaoxu's avatar ZhangXiaoxu Committed by Trond Myklebust
Browse files

nfs: fix xfstest generic/099 failed on nfsv3 



After setxattr, the nfsv3 cached the acl which set by user.

But at the backend, the shared file system (eg. ext4) will check
the acl, if it can merged with mode, it won't add acl to the file.
So, the nfsv3 cached acl is redundant.

Don't 'set_cached_acl' when setxattr.

Signed-off-by: default avatarZhangXiaoxu <zhangxiaoxu5@huawei.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent 2cde04e9

fs/nfs/nfs3acl.c

+0 −2
Original line number Diff line number Diff line
@@ -222,8 +222,6 @@ static int __nfs3_proc_setacls(struct inode *inode, struct posix_acl *acl, 
	switch (status) {

		case 0:

			status = nfs_refresh_inode(inode, fattr);

			set_cached_acl(inode, ACL_TYPE_ACCESS, acl);

			set_cached_acl(inode, ACL_TYPE_DEFAULT, dfacl);

			break;

		case -EPFNOSUPPORT:

		case -EPROTONOSUPPORT: