Commit debf6d84 authored Mar 02, 2015 by Roberta Dobrescu Committed by Jonathan Cameron Mar 09, 2015

iio: accel: mma9551: Check gpiod_to_irq return value



The return value of gpiod_to_irq should be checked before giving
it to devm_request_threaded_irq in order to not pass an error
code in case it fails.

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Reviewed-by: Vlad Dogaru <vlad.dogaru@intel.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

parent 4a428bf3

drivers/iio/accel/mma9551.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -425,7 +425,11 @@ static int mma9551_gpio_probe(struct iio_dev *indio_dev)
		return PTR_ERR(gpio);
		}

		data->irqs[i] = gpiod_to_irq(gpio);
		ret = gpiod_to_irq(gpio);
		if (ret < 0)
		return ret;

		data->irqs[i] = ret;
		ret = devm_request_threaded_irq(dev, data->irqs[i],
		NULL, mma9551_event_handler,
		IRQF_TRIGGER_RISING \| IRQF_ONESHOT,