Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit debea2cd authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David S. Miller
Browse files

net: cxgb3_main: Fix a resource leak in a error path in 'init_one()' 



A call to 'kfree_skb()' is missing in the error handling path of
'init_one()'.
This is already present in 'remove_one()' but is missing here.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5c4e2e1a

drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c

+4 −1
Original line number Diff line number Diff line
@@ -3269,7 +3269,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) 
	if (!adapter->regs) {

		dev_err(&pdev->dev, "cannot map device registers\n");

		err = -ENOMEM;

		goto out_free_adapter;

		goto out_free_adapter_nofail;

	}



	adapter->pdev = pdev;
@@ -3397,6 +3397,9 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) 
		if (adapter->port[i])

			free_netdev(adapter->port[i]);



out_free_adapter_nofail:

	kfree_skb(adapter->nofail_skb);



out_free_adapter:

	kfree(adapter);