Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de7b9aa6 authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

usbtmc: more sanity checking for packet size 



A malicious device can make the driver divide ny zero
with a nonsense maximum packet size.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20190820092826.17694-1-oneukum@suse.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3afa758c

drivers/usb/class/usbtmc.c

+3 −0
Original line number Diff line number Diff line
@@ -2362,8 +2362,11 @@ static int usbtmc_probe(struct usb_interface *intf, 
		goto err_put;

	}



	retcode = -EINVAL;

	data->bulk_in = bulk_in->bEndpointAddress;

	data->wMaxPacketSize = usb_endpoint_maxp(bulk_in);

	if (!data->wMaxPacketSize)

		goto err_put;

	dev_dbg(&intf->dev, "Found bulk in endpoint at %u\n", data->bulk_in);



	data->bulk_out = bulk_out->bEndpointAddress;