Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de75577c authored by Julia Lawall's avatar Julia Lawall Committed by Takashi Iwai
Browse files

ALSA: sound/aoa/fabrics/layout.c: remove unneeded kfree 

The label outnodev is only used when kzalloc has not yet taken place or has
failed, so there is no need for the call for kfree under this label.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier x;
expression E1!=0,E2,E3,E4;
statement S;
iterator I;
@@

(
if (...) { ... when != kfree(x)
               when != x = E3
               when != E3 = x
*  return ...;
 }
... when != x = E2
    when != I(...,x,...) S
if (...) { ... when != x = E4
 kfree(x); ... return ...; }
)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 1b004d03

sound/aoa/fabrics/layout.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1073,10 +1073,10 @@ static int aoa_fabric_layout_probe(struct soundbus_dev *sdev) 
	sdev->pcmid = -1;

	sdev->pcmid = -1;

	list_del(&ldev->list);

	list_del(&ldev->list);

	layouts_list_items--;

	layouts_list_items--;

	kfree(ldev);

 outnodev:

 outnodev:

 	of_node_put(sound);

 	of_node_put(sound);

 	layout_device = NULL;

 	layout_device = NULL;

 	kfree(ldev);

	return -ENODEV;

	return -ENODEV;

}

}