Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de467c11 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by David S. Miller
Browse files

fjes: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Yangtao Li <tiny.windzz@gmail.com>
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 438ac880

drivers/net/fjes/fjes_debugfs.c

+2 −13
Original line number Diff line number Diff line
@@ -52,20 +52,11 @@ DEFINE_SHOW_ATTRIBUTE(fjes_dbg_status); 
void fjes_dbg_adapter_init(struct fjes_adapter *adapter)

{

	const char *name = dev_name(&adapter->plat_dev->dev);

	struct dentry *pfile;



	adapter->dbg_adapter = debugfs_create_dir(name, fjes_debug_root);

	if (!adapter->dbg_adapter) {

		dev_err(&adapter->plat_dev->dev,

			"debugfs entry for %s failed\n", name);

		return;

	}



	pfile = debugfs_create_file("status", 0444, adapter->dbg_adapter,

				    adapter, &fjes_dbg_status_fops);

	if (!pfile)

		dev_err(&adapter->plat_dev->dev,

			"debugfs status for %s failed\n", name);

	debugfs_create_file("status", 0444, adapter->dbg_adapter, adapter,

			    &fjes_dbg_status_fops);

}



void fjes_dbg_adapter_exit(struct fjes_adapter *adapter)
@@ -77,8 +68,6 @@ void fjes_dbg_adapter_exit(struct fjes_adapter *adapter) 
void fjes_dbg_init(void)

{

	fjes_debug_root = debugfs_create_dir(fjes_driver_name, NULL);

	if (!fjes_debug_root)

		pr_info("init of debugfs failed\n");

}



void fjes_dbg_exit(void)