Commit ddd6e526 authored Oct 17, 2023 by zhujun2 Committed by Greg Kroah-Hartman Nov 28, 2023

selftests/efivarfs: create-read: fix a resource leak



[ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ]

The opened file should be closed in main(), otherwise resource
leak will occur that this problem was discovered by code reading

Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 437e0fa9

tools/testing/selftests/efivarfs/create-read.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -32,8 +32,10 @@ int main(int argc, char **argv)
		rc = read(fd, buf, sizeof(buf));
		if (rc != 0) {
		fprintf(stderr, "Reading a new var should return EOF\n");
		close(fd);
		return EXIT_FAILURE;
		}

		close(fd);
		return EXIT_SUCCESS;
		}