Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ddb07fba authored by Wen Yang's avatar Wen Yang Committed by Viresh Kumar
Browse files

cpufreq: maple: fix possible object reference leak 



The call to of_cpu_device_node_get returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./drivers/cpufreq/maple-cpufreq.c:213:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 177, but without a corresponding object release within this function.

Signed-off-by: default avatarWen Yang <wen.yang99@zte.com.cn>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 7c468966

drivers/cpufreq/maple-cpufreq.c

+1 −1
Original line number Diff line number Diff line
@@ -210,7 +210,7 @@ static int __init maple_cpufreq_init(void) 
	 */

	valp = of_get_property(cpunode, "clock-frequency", NULL);

	if (!valp)

		return -ENODEV;

		goto bail_noprops;

	max_freq = (*valp)/1000;

	maple_cpu_freqs[0].frequency = max_freq;

	maple_cpu_freqs[1].frequency = max_freq/2;