Commit dd914b40 authored Jan 17, 2006 by Amnon Aaronsohn Committed by David S. Miller Jan 17, 2006

[PKT_SCHED] sch_prio: fix qdisc bands init

Currently when PRIO is configured to use N bands, it lets the packets be
directed to any of the bands 0..N-1. However, PRIO attaches a fifo qdisc
only to the bands that appear in the priomap; the rest of the N bands
remain with a noop qdisc attached. This patch changes PRIO's behavior so
that it attaches a fifo qdisc to all of the N bands.

Signed-off-by: Amnon Aaronsohn <bla@cs.huji.ac.il>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9343e79a

net/sched/sch_prio.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -228,14 +228,13 @@ static int prio_tune(struct Qdisc sch, struct rtattr opt)
		}
		sch_tree_unlock(sch);

		for (i=0; i<=TC_PRIO_MAX; i++) {
		int band = q->prio2band[i];
		if (q->queues[band] == &noop_qdisc) {
		for (i=0; i<q->bands; i++) {
		if (q->queues[i] == &noop_qdisc) {
		struct Qdisc *child;
		child = qdisc_create_dflt(sch->dev, &pfifo_qdisc_ops);
		if (child) {
		sch_tree_lock(sch);
		child = xchg(&q->queues[band], child);
		child = xchg(&q->queues[i], child);

		if (child != &noop_qdisc)
		qdisc_destroy(child);