Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dcc13bcb authored by Rodrigo Vivi's avatar Rodrigo Vivi Committed by Daniel Vetter
Browse files

drm/i915: Don't return error on sink crc stop. 



If we got to the point where we are trying to stop sink CRC
the main output of this function was already gotten properly,
so don't return the error and let userspace use the crc data.

Let's replace the errnos returns with some log messages.

Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: default avatarRafael Antognolli <rafael.antognolli@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent afe0d67e

drivers/gpu/drm/i915/intel_dp.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -4021,12 +4021,12 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc) 




stop:

stop:

	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK, &buf) < 0) {

	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK, &buf) < 0) {

		ret = -EIO;

		DRM_DEBUG_KMS("Sink CRC couldn't be stopped properly\n");

		goto out;

		goto out;

	}

	}

	if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_TEST_SINK,

	if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_TEST_SINK,

			       buf & ~DP_TEST_SINK_START) < 0) {

			       buf & ~DP_TEST_SINK_START) < 0) {

		ret = -EIO;

		DRM_DEBUG_KMS("Sink CRC couldn't be stopped properly\n");

		goto out;

		goto out;

	}

	}

out:

out: