Commit dc9eab6f authored Feb 13, 2017 by Paul Durrant Committed by Boris Ostrovsky Feb 13, 2017

xen/privcmd: return -ENOTTY for unimplemented IOCTLs



The code sets the default return code to -ENOSYS but then overrides this
to -EINVAL in the switch() statement's default case, which is clearly
silly.

This patch removes the override and sets the default return code to
-ENOTTY, which is the conventional return for an unimplemented ioctl.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

parent fd8aa909

drivers/xen/privcmd.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -551,7 +551,7 @@ static long privcmd_ioctl_mmap_batch(void __user *udata, int version)
		static long privcmd_ioctl(struct file *file,
		unsigned int cmd, unsigned long data)
		{
		int ret = -ENOSYS;
		int ret = -ENOTTY;
		void __user udata = (void __user ) data;

		switch (cmd) {
		@@ -572,7 +572,6 @@ static long privcmd_ioctl(struct file *file,
		break;

		default:
		ret = -EINVAL;
		break;
		}