Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc8c2f0d authored by Miquel Raynal's avatar Miquel Raynal Committed by Greg Kroah-Hartman
Browse files

net: ieee802154: Return meaningful error codes from the netlink helpers 



commit 79c37ca73a6e9a33f7b2b7783ba6af07a448c8a9 upstream.

Returning -1 does not indicate anything useful.

Use a standard and meaningful error code instead.

Fixes: a26c5fd7 ("nl802154: add support for security layer")
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Acked-by: default avatarAlexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20220125121426.848337-6-miquel.raynal@bootlin.com


Signed-off-by: default avatarStefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6f38d3a6

net/ieee802154/nl802154.c

+4 −4
Original line number Diff line number Diff line
@@ -1457,7 +1457,7 @@ static int nl802154_send_key(struct sk_buff *msg, u32 cmd, u32 portid, 


	hdr = nl802154hdr_put(msg, portid, seq, flags, cmd);

	if (!hdr)

		return -1;

		return -ENOBUFS;



	if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex))

		goto nla_put_failure;
@@ -1650,7 +1650,7 @@ static int nl802154_send_device(struct sk_buff *msg, u32 cmd, u32 portid, 


	hdr = nl802154hdr_put(msg, portid, seq, flags, cmd);

	if (!hdr)

		return -1;

		return -ENOBUFS;



	if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex))

		goto nla_put_failure;
@@ -1828,7 +1828,7 @@ static int nl802154_send_devkey(struct sk_buff *msg, u32 cmd, u32 portid, 


	hdr = nl802154hdr_put(msg, portid, seq, flags, cmd);

	if (!hdr)

		return -1;

		return -ENOBUFS;



	if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex))

		goto nla_put_failure;
@@ -2004,7 +2004,7 @@ static int nl802154_send_seclevel(struct sk_buff *msg, u32 cmd, u32 portid, 


	hdr = nl802154hdr_put(msg, portid, seq, flags, cmd);

	if (!hdr)

		return -1;

		return -ENOBUFS;



	if (nla_put_u32(msg, NL802154_ATTR_IFINDEX, dev->ifindex))

		goto nla_put_failure;