Unverified Commit dc62f951 authored Apr 17, 2019 by Wei Yongjun Committed by Mark Brown Apr 17, 2019

regulator: stm32-pwr: Fix return value check in stm32_pwr_regulator_probe()



In case of error, the function of_iomap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 6cdae817 ("regulator: Add support for stm32 power regulators")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 82f26185

drivers/regulator/stm32-pwr.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -140,9 +140,9 @@ static int stm32_pwr_regulator_probe(struct platform_device *pdev)
		int i, ret = 0;

		base = of_iomap(np, 0);
		if (IS_ERR(base)) {
		if (!base) {
		dev_err(&pdev->dev, "Unable to map IO memory\n");
		return PTR_ERR(base);
		return -ENOMEM;
		}

		config.dev = &pdev->dev;