Commit dc0867c4 authored Jan 06, 2023 by Bartosz Golaszewski Committed by Greg Kroah-Hartman Feb 06, 2023

spi: spidev: remove debug messages that access spidev->spi without locking



[ Upstream commit 6b35b173dbc1711f8d272e3f322d2ad697015919 ]

The two debug messages in spidev_open() dereference spidev->spi without
taking the lock and without checking if it's not null. This can lead to
a crash. Drop the messages as they're not needed - the user-space will
get informed about ENOMEM with the syscall return value.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20230106100719.196243-2-brgl@bgdev.pl


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 0dfd34fb

drivers/spi/spidev.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -588,7 +588,6 @@ static int spidev_open(struct inode inode, struct file filp)
		if (!spidev->tx_buffer) {
		spidev->tx_buffer = kmalloc(bufsiz, GFP_KERNEL);
		if (!spidev->tx_buffer) {
		dev_dbg(&spidev->spi->dev, "open/ENOMEM\n");
		status = -ENOMEM;
		goto err_find_dev;
		}
		@@ -597,7 +596,6 @@ static int spidev_open(struct inode inode, struct file filp)
		if (!spidev->rx_buffer) {
		spidev->rx_buffer = kmalloc(bufsiz, GFP_KERNEL);
		if (!spidev->rx_buffer) {
		dev_dbg(&spidev->spi->dev, "open/ENOMEM\n");
		status = -ENOMEM;
		goto err_alloc_rx_buf;
		}