Commit dbf13624 authored Sep 04, 2023 by Christophe JAILLET Committed by Greg Kroah-Hartman Nov 20, 2023

regmap: debugfs: Fix a erroneous check after snprintf()



[ Upstream commit d3601857e14de6369f00ae19564f1d817d175d19 ]

This error handling looks really strange.
Check if the string has been truncated instead.

Fixes: f0c2319f ("regmap: Expose the driver name in debugfs")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/8595de2462c490561f70020a6d11f4d6b652b468.1693857825.git.christophe.jaillet@wanadoo.fr


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent af50165c

drivers/base/regmap/regmap-debugfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -49,7 +49,7 @@ static ssize_t regmap_name_read_file(struct file *file,
		name = map->dev->driver->name;

		ret = snprintf(buf, PAGE_SIZE, "%s\n", name);
		if (ret < 0) {
		if (ret >= PAGE_SIZE) {
		kfree(buf);
		return ret;
		}