Commit dbbe358b authored Mar 02, 2019 by Oded Gabbay Committed by Greg Kroah-Hartman Mar 02, 2019

habanalabs: use %px instead of %p in error print



When parsing the address of an internal command buffer, the driver prints
an error if the buffer's address is not in the range of the device's DRAM
or SRAM memory address space.

Use %px to print the real address that the user gave the driver and not a
hashed value, so the user will get a clue regarding the origin of his
error.

Note that if the print occurs, the pointer that is printed is a
user's virtual address and not some kind of physical address.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 99f63620

drivers/misc/habanalabs/goya/goya.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4293,7 +4293,7 @@ static int goya_parse_cb_no_ext_quque(struct hl_device *hdev,
		return 0;

		dev_err(hdev->dev,
		"Internal CB address %p + 0x%x is not in SRAM nor in DRAM\n",
		"Internal CB address %px + 0x%x is not in SRAM nor in DRAM\n",
		parser->user_cb, parser->user_cb_size);

		return -EFAULT;