Commit db9fda52 authored Jan 11, 2024 by Kunwu Chan Committed by Greg Kroah-Hartman Jan 25, 2024

net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe



[ Upstream commit 776dac5a662774f07a876b650ba578d0a62d20db ]

devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.

Fixes: 05bd97fc ("net: dsa: Add Vitesse VSC73xx DSA router driver")
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240111072018.75971-1-chentao@kylinos.cn


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 8efe3e8a

drivers/net/dsa/vitesse-vsc73xx-core.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1108,6 +1108,8 @@ static int vsc73xx_gpio_probe(struct vsc73xx *vsc)

		vsc->gc.label = devm_kasprintf(vsc->dev, GFP_KERNEL, "VSC%04x",
		vsc->chipid);
		if (!vsc->gc.label)
		return -ENOMEM;
		vsc->gc.ngpio = 4;
		vsc->gc.owner = THIS_MODULE;
		vsc->gc.parent = vsc->dev;