Commit dafbe56f authored Apr 17, 2019 by Bart Van Assche Committed by Martin K. Petersen Apr 29, 2019

scsi: qla2xxx: Remove the fcport test from qla_nvme_abort_work()

Testing whether a pointer is not NULL after it has been dereferenced is not
useful. Hence remove the if (fcport) test. This was detected by Coverity.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 12975426

drivers/scsi/qla2xxx/qla_nvme.c

+3 −4

Original line number	Original line	Diff line number	Diff line
	@@ -186,7 +186,6 @@ static void qla_nvme_abort_work(struct work_struct *work)
	struct qla_hw_data *ha = fcport->vha->hw;		struct qla_hw_data *ha = fcport->vha->hw;
	int rval;		int rval;

	if (fcport)
	ql_dbg(ql_dbg_io, fcport->vha, 0xffff,		ql_dbg(ql_dbg_io, fcport->vha, 0xffff,
	"%s called for sp=%p, hndl=%x on fcport=%p deleted=%d\n",		"%s called for sp=%p, hndl=%x on fcport=%p deleted=%d\n",
	__func__, sp, sp->handle, fcport, fcport->deleted);		__func__, sp, sp->handle, fcport, fcport->deleted);