Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dadcd398 authored by Johan Hovold's avatar Johan Hovold Committed by Marc Kleine-Budde
Browse files

can: peak_usb: fix product-id endianness in error message 



Make sure to use the USB device product-id stored in host-byte order in
a probe error message.

Also remove a redundant reassignment of the local usb_dev variable which
had already been used to retrieve the product id.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent f2a918b4

drivers/net/can/usb/peak_usb/pcan_usb_core.c

+1 −3
Original line number Diff line number Diff line
@@ -908,8 +908,6 @@ static int peak_usb_probe(struct usb_interface *intf, 
	const struct peak_usb_adapter *peak_usb_adapter = NULL;

	int i, err = -ENOMEM;



	usb_dev = interface_to_usbdev(intf);



	/* get corresponding PCAN-USB adapter */

	for (i = 0; i < ARRAY_SIZE(peak_usb_adapters_list); i++)

		if (peak_usb_adapters_list[i]->device_id == usb_id_product) {
@@ -920,7 +918,7 @@ static int peak_usb_probe(struct usb_interface *intf, 
	if (!peak_usb_adapter) {

		/* should never come except device_id bad usage in this file */

		pr_err("%s: didn't find device id. 0x%x in devices list\n",

			PCAN_USB_DRIVER_NAME, usb_dev->descriptor.idProduct);

			PCAN_USB_DRIVER_NAME, usb_id_product);

		return -ENODEV;

	}