Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit daa6630a authored by Nicolas Dichtel's avatar Nicolas Dichtel Committed by David S. Miller
Browse files

openvswitch: warn about missing first netlink attribute 



The first netlink attribute (value 0) must always be defined
as none/unspec.

Because we cannot change an existing UAPI, I add a comment to point the
mistake and avoid to propagate it in a new ovs API in the future.

Signed-off-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0db47e3d

include/uapi/linux/openvswitch.h

+1 −0
Original line number Diff line number Diff line
@@ -343,6 +343,7 @@ enum ovs_key_attr { 
#define OVS_KEY_ATTR_MAX (__OVS_KEY_ATTR_MAX - 1)



enum ovs_tunnel_key_attr {

	/* OVS_TUNNEL_KEY_ATTR_NONE, standard nl API requires this attribute! */

	OVS_TUNNEL_KEY_ATTR_ID,                 /* be64 Tunnel ID */

	OVS_TUNNEL_KEY_ATTR_IPV4_SRC,           /* be32 src IP address. */

	OVS_TUNNEL_KEY_ATTR_IPV4_DST,           /* be32 dst IP address. */