Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit da43c262 authored by Ovidiu Panait's avatar Ovidiu Panait Committed by Greg Kroah-Hartman
Browse files

crypto: sahara - fix ahash selftest failure 



[ Upstream commit afffcf3db98b9495114b79d5381f8cc3f69476fb ]

update() calls should not modify the result buffer, so add an additional
check for "rctx->last" to make sure that only the final hash value is
copied into the buffer.

Fixes the following selftest failure:
alg: ahash: sahara-sha256 update() used result buffer on test vector 3,
cfg="init+update+final aligned buffer"

Fixes: 5a2bb93f ("crypto: sahara - add support for SHA1/256")
Signed-off-by: default avatarOvidiu Panait <ovidiu.panait@windriver.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent beb815a0

drivers/crypto/sahara.c

+1 −1
Original line number Diff line number Diff line
@@ -1031,7 +1031,7 @@ static int sahara_sha_process(struct ahash_request *req) 


	memcpy(rctx->context, dev->context_base, rctx->context_size);



	if (req->result)

	if (req->result && rctx->last)

		memcpy(req->result, rctx->context, rctx->digest_size);



	return 0;