Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9e5d174 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Marc Kleine-Budde
Browse files

can: kvaser_usb: Use struct_size() in alloc_candev()



One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = alloc(sizeof(struct foo) + count * sizeof(void *));

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = alloc(struct_size(instance, entry, count));

This code was detected with the help of Coccinelle.

Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 2d91fdcc
Loading
Loading
Loading
Loading
+1 −2
Original line number Original line Diff line number Diff line
@@ -643,8 +643,7 @@ static int kvaser_usb_init_one(struct kvaser_usb *dev,
			return err;
			return err;
	}
	}


	netdev = alloc_candev(sizeof(*priv) +
	netdev = alloc_candev(struct_size(priv, tx_contexts, dev->max_tx_urbs),
			      dev->max_tx_urbs * sizeof(*priv->tx_contexts),
			      dev->max_tx_urbs);
			      dev->max_tx_urbs);
	if (!netdev) {
	if (!netdev) {
		dev_err(&dev->intf->dev, "Cannot alloc candev\n");
		dev_err(&dev->intf->dev, "Cannot alloc candev\n");