Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9afe243 authored by Shuah Khan's avatar Shuah Khan Committed by Greg Kroah-Hartman
Browse files

selftests: firmware: Fix it to do root uid check and skip 



[ Upstream commit c65e41538b04e0d64a673828745a00cb68a24371 ]

firmware attempts to load test modules that require root access
and fail. Fix it to check for root uid and exit with skip code
instead.

Before this fix:

selftests: firmware: fw_run_tests.sh
modprobe: ERROR: could not insert 'test_firmware': Operation not permitted
You must have the following enabled in your kernel:
CONFIG_TEST_FIRMWARE=y
CONFIG_FW_LOADER=y
CONFIG_FW_LOADER_USER_HELPER=y
CONFIG_IKCONFIG=y
CONFIG_IKCONFIG_PROC=y
not ok 1 selftests: firmware: fw_run_tests.sh # SKIP

With this fix:

selftests: firmware: fw_run_tests.sh
skip all tests: must be run as root
not ok 1 selftests: firmware: fw_run_tests.sh # SKIP

Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Reviwed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 434de487

tools/testing/selftests/firmware/fw_lib.sh

+6 −0
Original line number Diff line number Diff line
@@ -34,6 +34,12 @@ test_modprobe() 


check_mods()

{

	local uid=$(id -u)

	if [ $uid -ne 0 ]; then

		echo "skip all tests: must be run as root" >&2

		exit $ksft_skip

	fi



	trap "test_modprobe" EXIT

	if [ ! -d $DIR ]; then

		modprobe test_firmware