Commit d9972f47 authored Jul 07, 2015 by Felipe Balbi

usb: dwc3: core: remove unnecessary dev_warn()



When a SoC supports both PHY interfaces but
doesn't define HSPHY in DT/pdata, we will get
an unnecessary dev_warn() which can mislead users
into thinking that they're missing something.

Instead, let's just silently rely on a correct
default. If the HW default is wrong, then HSPHY
is required and USB won't work, this will be
motivation enough for engineers to patch their
way into a working setup.

Reported-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent 88167fc0

drivers/usb/dwc3/core.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -455,8 +455,6 @@ static int dwc3_phy_setup(struct dwc3 *dwc)
		reg \|= DWC3_GUSB2PHYCFG_ULPI_UTMI;
		dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
		} else {
		dev_warn(dwc->dev, "HSPHY Interface not defined\n");

		/* Relying on default value. */
		if (!(reg & DWC3_GUSB2PHYCFG_ULPI_UTMI))
		break;