Commit d996530b authored Oct 30, 2023 by Tony Lindgren Committed by Greg Kroah-Hartman Nov 28, 2023

ASoC: ti: omap-mcbsp: Fix runtime PM underflow warnings



[ Upstream commit fbb74e56378d8306f214658e3d525a8b3f000c5a ]

We need to check for an active device as otherwise we get warnings
for some mcbsp instances for "Runtime PM usage count underflow!".

Reported-by: Andreas Kemnade <andreas@kemnade.info>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20231030052340.13415-1-tony@atomide.com


Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 6d703922

sound/soc/ti/omap-mcbsp.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -74,6 +74,7 @@ static int omap2_mcbsp_set_clks_src(struct omap_mcbsp *mcbsp, u8 fck_src_id)
		return -EINVAL;
		}

		if (mcbsp->active)
		pm_runtime_put_sync(mcbsp->dev);

		r = clk_set_parent(mcbsp->fclk, fck_src);
		@@ -84,6 +85,7 @@ static int omap2_mcbsp_set_clks_src(struct omap_mcbsp *mcbsp, u8 fck_src_id)
		return r;
		}

		if (mcbsp->active)
		pm_runtime_get_sync(mcbsp->dev);

		clk_put(fck_src);