Commit d95947c0 authored Dec 04, 2018 by Sean Young Committed by Mauro Carvalho Chehab Dec 05, 2018

media: dib7000p: Remove dead code



Clang warns that 'interleaving' is assigned to itself in this function.

drivers/media/dvb-frontends/dib7000p.c:1874:15: warning: explicitly
assigning value of variable of type 'int' to itself [-Wself-assign]
        interleaving = interleaving;
        ~~~~~~~~~~~~ ^ ~~~~~~~~~~~~
1 warning generated.

Just remove the self-assign and leave existing code in place for now.

Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent d695eb5b

drivers/media/dvb-frontends/dib7000p.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -1871,10 +1871,13 @@ static u32 dib7000p_get_time_us(struct dvb_frontend *demod)
		break;
		}

		interleaving = interleaving;

		denom = bits_per_symbol * rate_num * fft_div * 384;

		/*
		* FIXME: check if the math makes sense. If so, fill the
		* interleaving var.
		*/

		/* If calculus gets wrong, wait for 1s for the next stats */
		if (!denom)
		return 0;