Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d950f84c authored by Richard Guy Briggs's avatar Richard Guy Briggs Committed by Paul Moore
Browse files

selinux: convert WARN_ONCE() to printk() in selinux_nlmsg_perm() 



Convert WARN_ONCE() to printk() in selinux_nlmsg_perm().

After conversion from audit_log() in commit e173fb26, WARN_ONCE() was
deemed too alarmist, so switch it to printk().

Signed-off-by: default avatarRichard Guy Briggs <rgb@redhat.com>
[PM: Changed to printk(WARNING) so we catch all of the different
 invalid netlink messages.  In Richard's defense, he brought this
 point up earlier, but I didn't understand his point at the time.]
Signed-off-by: default avatarPaul Moore <pmoore@redhat.com>
parent 923190d3

security/selinux/hooks.c

+4 −3
Original line number Diff line number Diff line
@@ -4727,7 +4727,8 @@ static int selinux_nlmsg_perm(struct sock *sk, struct sk_buff *skb) 
	err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type, &perm);

	if (err) {

		if (err == -EINVAL) {

			WARN_ONCE(1, "selinux_nlmsg_perm: unrecognized netlink message:"

			printk(KERN_WARNING

			       "SELinux: unrecognized netlink message:"

			       " protocol=%hu nlmsg_type=%hu sclass=%hu\n",

			       sk->sk_protocol, nlh->nlmsg_type, sksec->sclass);

			if (!selinux_enforcing || security_get_allow_unknown())