Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d94fbfcd authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Greg Kroah-Hartman
Browse files

phy: rockchip-typec: Fix unsigned comparison with less than zero 



[ Upstream commit f765c59c5a72546a2d74a92ae5d0eb0329d8e247 ]

The dp and ufp are defined as bool type, the return value type of
function extcon_get_state should be int, so the type of dp and ufp
are modified to int.

./drivers/phy/rockchip/phy-rockchip-typec.c:827:12-14: WARNING: Unsigned expression compared with zero: dp > 0.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3962


Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230213035709.99027-1-jiapeng.chong@linux.alibaba.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f0ee43d6

drivers/phy/rockchip/phy-rockchip-typec.c

+1 −2
Original line number Diff line number Diff line
@@ -808,9 +808,8 @@ static int tcphy_get_mode(struct rockchip_typec_phy *tcphy) 
	struct extcon_dev *edev = tcphy->extcon;

	union extcon_property_value property;

	unsigned int id;

	bool ufp, dp;

	u8 mode;

	int ret;

	int ret, ufp, dp;



	if (!edev)

		return MODE_DFP_USB;