Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8f4494e authored by Sebastian Reichel's avatar Sebastian Reichel Committed by Linus Walleij
Browse files

pinctrl: mcp23s08: drop comment about missing irq support 



The driver supports using mcp23xxx as interrupt controller, so
let's drop all comments stating otherwise.

Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent ce9bd0a0

drivers/pinctrl/pinctrl-mcp23s08.c

+2 −17
Original line number Diff line number Diff line 
/*

 * MCP23S08 SPI/I2C GPIO gpio expander driver

 *

 * The inputs and outputs of the mcp23s08, mcp23s17, mcp23008 and mcp23017 are

 * supported.

 * For the I2C versions of the chips (mcp23008 and mcp23017) generation of

 * interrupts is also supported.

 * The hardware of the SPI versions of the chips (mcp23s08 and mcp23s17) is

 * also capable of generating interrupts, but the linux driver does not

 * support that yet.

 */

/* MCP23S08 SPI/I2C GPIO driver */



#include <linux/kernel.h>

#include <linux/device.h>
@@ -27,7 +17,7 @@ 
#include <linux/pinctrl/pinconf.h>

#include <linux/pinctrl/pinconf-generic.h>



/**

/*

 * MCP types supported by driver

 */

#define MCP_TYPE_S08	0
@@ -1131,11 +1121,6 @@ static int mcp23s08_probe(struct spi_device *spi) 
	}

	data->ngpio = ngpio;



	/* NOTE:  these chips have a relatively sane IRQ framework, with

	 * per-signal masking and level/edge triggering.  It's not yet

	 * handled here...

	 */



	return 0;

}

include/linux/spi/mcp23s08.h

+0 −3
Original line number Diff line number Diff line 


/* FIXME driver should be able to handle IRQs...  */



struct mcp23s08_platform_data {

	/* For mcp23s08, up to 4 slaves (numbered 0..3) can share one SPI

	 * chipselect, each providing 1 gpio_chip instance with 8 gpios.