Commit d8d1d354 authored Dec 07, 2020 by Anant Thazhemadam Committed by Greg Kroah-Hartman Nov 17, 2021

media: usb: dvd-usb: fix uninit-value bug in dibusb_read_eeprom_byte()



[ Upstream commit 899a61a3305d49e8a712e9ab20d0db94bde5929f ]

In dibusb_read_eeprom_byte(), if dibusb_i2c_msg() fails, val gets
assigned an value that's not properly initialized.
Using kzalloc() in place of kmalloc() for the buffer fixes this issue,
as the val can now be set to 0 in the event dibusb_i2c_msg() fails.

Reported-by:  <syzbot+e27b4fd589762b0b9329@syzkaller.appspotmail.com>
Tested-by:  <syzbot+e27b4fd589762b0b9329@syzkaller.appspotmail.com>
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 382e7b64

drivers/media/usb/dvb-usb/dibusb-common.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -223,7 +223,7 @@ int dibusb_read_eeprom_byte(struct dvb_usb_device d, u8 offs, u8 val)
		u8 *buf;
		int rc;

		buf = kmalloc(2, GFP_KERNEL);
		buf = kzalloc(2, GFP_KERNEL);
		if (!buf)
		return -ENOMEM;