Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d87e9626 authored by Sergio Paracuellos's avatar Sergio Paracuellos Committed by Greg Kroah-Hartman
Browse files

staging: ks7010: refactor hostif_sme_power_mgmt_set function 



This commit refactor hostif_sme_power_mgmt_set avoiding to
use switch-case statement and simplifying data paths. This
improves readability.

Signed-off-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0d8be306

drivers/staging/ks7010/ks_hostif.c

+10 −23
Original line number Diff line number Diff line
@@ -1880,36 +1880,23 @@ void hostif_sme_multicast_set(struct ks_wlan_private *priv) 
	spin_unlock(&priv->multicast_spin);

}



static

void hostif_sme_power_mgmt_set(struct ks_wlan_private *priv)

static void hostif_sme_power_mgmt_set(struct ks_wlan_private *priv)

{

	u32 mode, wake_up, receive_dtims;



	switch (priv->reg.power_mgmt) {

	case POWER_MGMT_SAVE1:

		mode = (priv->reg.operation_mode == MODE_INFRASTRUCTURE) ?

			POWER_SAVE : POWER_ACTIVE;

		wake_up = 0;

		receive_dtims = 0;

		break;

	case POWER_MGMT_SAVE2:

		if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {

			mode = POWER_SAVE;

			wake_up = 0;

			receive_dtims = 1;

		} else {

	if (priv->reg.power_mgmt != POWER_MGMT_SAVE1 &&

	    priv->reg.power_mgmt != POWER_MGMT_SAVE2) {

		mode = POWER_ACTIVE;

		wake_up = 0;

		receive_dtims = 0;

		}

		break;

	case POWER_MGMT_ACTIVE:

	default:

		mode = POWER_ACTIVE;

	} else {

		mode = (priv->reg.operation_mode == MODE_INFRASTRUCTURE) ?

			POWER_SAVE : POWER_ACTIVE;

		wake_up = 0;

		receive_dtims = 0;

		break;

		receive_dtims = (priv->reg.operation_mode == MODE_INFRASTRUCTURE &&

				 priv->reg.power_mgmt == POWER_MGMT_SAVE2);

	}



	hostif_power_mgmt_request(priv, mode, wake_up, receive_dtims);

}