Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d84e4a5a authored by Salah Triki's avatar Salah Triki Committed by Luis de Bethencourt
Browse files

fs: befs: Remove redundant validation from befs_find_brun_direct 



The only caller of befs_find_brun_direct is befs_fblock2brun, which
already validates that the block is within the range of direct blocks.
So remove the duplicate validation.

Signed-off-by: default avatarSalah Triki <salah.triki@gmail.com>
Acked-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
parent 2dfa8a6e

fs/befs/datastream.c

+0 −8
Original line number Diff line number Diff line
@@ -249,17 +249,9 @@ befs_find_brun_direct(struct super_block *sb, const befs_data_stream *data, 
	int i;

	const befs_block_run *array = data->direct;

	befs_blocknr_t sum;

	befs_blocknr_t max_block =

	    data->max_direct_range >> BEFS_SB(sb)->block_shift;



	befs_debug(sb, "---> %s, find %lu", __func__, (unsigned long)blockno);



	if (blockno > max_block) {

		befs_error(sb, "%s passed block outside of direct region",

			   __func__);

		return BEFS_ERR;

	}



	for (i = 0, sum = 0; i < BEFS_NUM_DIRECT_BLOCKS;

	     sum += array[i].len, i++) {

		if (blockno >= sum && blockno < sum + (array[i].len)) {